Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configimplementation #42

Merged
merged 35 commits into from
May 6, 2024
Merged

Configimplementation #42

merged 35 commits into from
May 6, 2024

Conversation

Tentanus
Copy link
Collaborator

  • Implemented configfile.

  • The project still needs work on the listen directive. especially thinking about what ports are being used.

Tentanus and others added 28 commits December 6, 2023 11:18
…w ReturnException. WIP: still need to edit Client Class and generate correct response
@Tentanus Tentanus added the 💫enhancement New feature or request label Mar 28, 2024
@Tentanus Tentanus requested a review from saladuit March 28, 2024 13:58
@Tentanus Tentanus requested a review from lucienvb March 28, 2024 13:58
@Tentanus Tentanus self-assigned this Mar 28, 2024
@Tentanus Tentanus linked an issue Mar 28, 2024 that may be closed by this pull request
include/Client.hpp Outdated Show resolved Hide resolved
include/LocationSettings.hpp Show resolved Hide resolved
include/LocationSettings.hpp Show resolved Hide resolved
include/ReturnException.hpp Show resolved Hide resolved
include/Socket.hpp Outdated Show resolved Hide resolved
src/HTTPRequest.cpp Outdated Show resolved Hide resolved
src/HTTPResponse.cpp Show resolved Hide resolved
src/HTTPServer.cpp Outdated Show resolved Hide resolved
src/HTTPServer.cpp Outdated Show resolved Hide resolved
src/Poll.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@lucienvb lucienvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit!

@Tentanus Tentanus requested a review from saladuit April 2, 2024 13:03
Copy link
Owner

@saladuit saladuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik vind het lastig om hier nog eens door heen te gaan. In het vervolg protip. Als je zo'n grote pr maakt zorg dan dat je zoveel mogelijk extra info toevogd. Zoals 'hier ben ik niet zo zeker omdat, zus en zo' of 'dit zijn de belangrijke onderdelen waar ik nog deze vragen over heb'. Op die manier maak je het ook behapbaarder voor de gene die dingen nog na gaat. Ik ga hem voor nu gewoon approven en we zijn bij de eval wel wat er nog mis gaat

src/Poll.cpp Outdated Show resolved Hide resolved
src/Poll.cpp Show resolved Hide resolved
src/HTTPResponse.cpp Show resolved Hide resolved
src/FileManager.cpp Show resolved Hide resolved
include/LocationSettings.hpp Show resolved Hide resolved
include/HTTPRequest.hpp Show resolved Hide resolved
include/Socket.hpp Outdated Show resolved Hide resolved
include/Client.hpp Outdated Show resolved Hide resolved
@Tentanus Tentanus requested a review from saladuit April 28, 2024 18:36
@saladuit saladuit merged commit 0e537d3 into main May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parser (Configuration File)
3 participants